-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add postgresql support #151
Feature add postgresql support #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and nice addition to openSTEF! I think many can benefit from postgresql support.
I found a few minor things we can improve. The most important one is that sql_db_type is now defined as a string. As there are only two options and different forms (lower and upper) are used throughout the code I think it is nice to implement is as an enum (https://www.geeksforgeeks.org/enum-in-python/). This way we get a bit more control and validation.
In addition, I see that there are conflicts with the main branch, please resolve these as well.
Let me know if you have questions about this.
edf2bdd
to
5b9ed03
Compare
Signed-off-by: Theo Pascoli <[email protected]>
a339a9c
to
c4f7656
Compare
I have:
Please let me know if you see anything else to change |
@alicecaron Looks good, I see that black is failing though. You can probably fix this by running |
Yes! I ran black on a new commit, it should be ok now @JanMaartenvanDoorn |
Signed-off-by: CARON Alice <[email protected]>
Signed-off-by: CARON Alice <[email protected]>
8f4bc76
to
bd8a2ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alicecaron Looks good now!
Summary:
This pull request adds support for PostgreSQL in addition to the existing MySQL support. To achieve this, a new environment variable sql_db_type has been introduced, allowing the user to choose between PostgreSQL and MySQL. By default, if the sql_db_type variable is not set, MySQL is selected.
Changes Made:
Please let me know if there are any questions or further modifications required.