Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(KTP-1279): Changed linear model scaling and improved sample weighting feature. #565

Merged
merged 25 commits into from
Oct 11, 2024
Merged

feature(KTP-1279): Changed linear model scaling and improved sample weighting feature. #565

merged 25 commits into from
Oct 11, 2024

Conversation

egordm
Copy link
Collaborator

@egordm egordm commented Oct 4, 2024

  • Minmax scaling doesn't weigh low peaks good enough.
  • Using quantile scaling now, where everything above p95 and below p5 has a sample weight of 1.
  • Using standard scaling for model features.

@github-actions github-actions bot added the feature New feature or request label Oct 4, 2024
egordm and others added 18 commits October 7, 2024 16:09
@egordm
feature(KTP-1279): Added additional test condition for linear model p…
f85f2e6 
…arams.

Signed-off-by: Egor Dmitriev <[email protected]>
@egordm
feature(KTP-1279): Added weight floor. Added documentation for sample…
6f4afa7 
… weight calculation.

Signed-off-by: Egor Dmitriev <[email protected]>
@actions-user
Format Python code with Black
6c5e67d 
Signed-off-by: black <[email protected]>
@clara-de-smet
Merge branch 'main' into feature/KTP-1279-linear-sample-weight
385c356 
Signed-off-by: Clara De Smet <[email protected]>
@clara-de-smet
Merge branch 'main' into feature/KTP-1279-linear-sample-weight
cada386 
Signed-off-by: Clara De Smet <[email protected]>
@actions-user
Format Python code with Black
75764b5 
Signed-off-by: black <[email protected]>
@clara-de-smet
Fixed linter suggestion
873e984 
Signed-off-by: Clara De Smet <[email protected]>
@clara-de-smet
Added documentation
5dbed25
@actions-user
Format Python code with Black
b5d2430 
Signed-off-by: black <[email protected]>
@clara-de-smet
Bumped version of black formatting
da443b7
@clara-de-smet
Updated documentation
b51c690
@actions-user
Format Python code with Black
fafc48b 
Signed-off-by: black <[email protected]>
@clara-de-smet
Removed blank line
ac5b8e3
@clara-de-smet
Merge branch 'feature/KTP-1279-linear-sample-weight' of https://githu…
be8d70c 
…b.com/OpenSTEF/openstef into feature/KTP-1279-linear-sample-weight
@actions-user
Format Python code with Black
0c80259 
Signed-off-by: black <[email protected]>
@clara-de-smet
Reformatting docs
f6a09a2
@clara-de-smet
Merge branch 'feature/KTP-1279-linear-sample-weight' of https://githu…
482953b 
…b.com/OpenSTEF/openstef into feature/KTP-1279-linear-sample-weight
@clara-de-smet
Reformatting docs
1143f1d
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@clara-de-smet clara-de-smet merged commit 08c9965 into main Oct 11, 2024
6 checks passed
@clara-de-smet clara-de-smet deleted the feature/KTP-1279-linear-sample-weight branch October 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clara-de-smet clara-de-smet clara-de-smet approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egordm @clara-de-smet @actions-user