Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilitator.progressRedeem #56

Merged
merged 15 commits into from
Feb 8, 2019
Merged

Facilitator.progressRedeem #56

merged 15 commits into from
Feb 8, 2019

Conversation

deepesh-kn
Copy link
Collaborator

⚠️ to be merged after #51 :⚠️
This PR includes the following.

  • Added progress redeem flow.
  • Added facilitator.md file.
  • Tested on actual geth.

Unit tests are not included.
Fixes: #32

@deepesh-kn deepesh-kn self-assigned this Feb 5, 2019
@0xsarvesh 0xsarvesh mentioned this pull request Feb 7, 2019
Merged
schemar
schemar approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very nice 👍
It is quite long so I did not check all the internals of all classes. Tests will assert the correct behavior 👍

makeitso

index.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Outdated Show resolved Hide resolved
src/Facilitator/FACILITATOR.MD Show resolved Hide resolved
src/Facilitator/FACILITATOR.MD Show resolved Hide resolved
src/Facilitator/Facilitator.js Outdated Show resolved Hide resolved
@0xsarvesh 0xsarvesh mentioned this pull request Feb 7, 2019
Merged
0xsarvesh
0xsarvesh reviewed Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@0xsarvesh 0xsarvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks.

index.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Outdated Show resolved Hide resolved
src/Facilitator/Facilitator.js Outdated Show resolved Hide resolved
src/Facilitator/Facilitator.js Show resolved Hide resolved
0xsarvesh
0xsarvesh approved these changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@0xsarvesh 0xsarvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 🙌
Some minor changes and open conversations.

test/Staker/approveStakeAmount.js Outdated Show resolved Hide resolved
src/utils/Message.js Outdated Show resolved Hide resolved
hobofan
hobofan approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@hobofan hobofan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only some minor comments.

src/ContractInteract/EIP20Gateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Show resolved Hide resolved
src/ContractInteract/EIP20Gateway.js Show resolved Hide resolved
src/Facilitator/FACILITATOR.MD Show resolved Hide resolved
@0xsarvesh 0xsarvesh merged commit 02dd233 into mosaicdao:develop Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobofan hobofan hobofan approved these changes

@0xsarvesh 0xsarvesh 0xsarvesh approved these changes

@schemar schemar schemar approved these changes

Assignees

@deepesh-kn deepesh-kn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepesh-kn @hobofan @schemar @0xsarvesh