Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilitator redeem #51

Merged
merged 11 commits into from
Feb 6, 2019
Merged

Facilitator redeem #51

merged 11 commits into from
Feb 6, 2019

Conversation

deepesh-kn
Copy link
Collaborator

  • Added facilitator's redeem flow.
    Fixes: Create Faciliator.redeem #28

  • This has been tested on actual geth.

  • Unit tests for facilitator are not there yet.

  • Unit tests for OSTPrime are not there yet.

@deepesh-kn deepesh-kn self-assigned this Feb 5, 2019
hobofan
hobofan approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@hobofan hobofan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a follow up ticket for the tests.

Otherwise LGTM! 🥇

@deepesh-kn
Copy link
Collaborator Author

Creates a follow up ticket #52

schemar
schemar suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice.

Comments in-line.

src/ContractInteract/EIP20CoGateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Outdated Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Show resolved Hide resolved
src/ContractInteract/EIP20CoGateway.js Outdated Show resolved Hide resolved
src/Facilitator/Facilitator.js Show resolved Hide resolved
src/Facilitator/Facilitator.js Outdated Show resolved Hide resolved
src/Redeemer/Redeemer.js Outdated Show resolved Hide resolved
src/Redeemer/Redeemer.js Outdated Show resolved Hide resolved
src/Redeemer/Redeemer.js Outdated Show resolved Hide resolved
schemar
schemar approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

src/ContractInteract/EIP20CoGateway.js Show resolved Hide resolved
src/Facilitator/Facilitator.js Show resolved Hide resolved
src/Facilitator/Facilitator.js Outdated Show resolved Hide resolved
@deepesh-kn deepesh-kn mentioned this pull request Feb 5, 2019
Merged
@0xsarvesh 0xsarvesh mentioned this pull request Feb 6, 2019
Merged
schemar
schemar approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. If I didn't understand it correctly and the check is not required, then you don't have to add it of course.

0xsarvesh
0xsarvesh approved these changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@0xsarvesh 0xsarvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🥇

@0xsarvesh 0xsarvesh merged commit 317a4bc into mosaicdao:develop Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobofan hobofan hobofan approved these changes

@0xsarvesh 0xsarvesh 0xsarvesh approved these changes

@schemar schemar schemar approved these changes

Assignees

@deepesh-kn deepesh-kn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepesh-kn @hobofan @schemar @0xsarvesh