Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/67 update test suite results #74

Merged
merged 19 commits into from
Nov 11, 2024
Merged

Feature/67 update test suite results #74

merged 19 commits into from
Nov 11, 2024

Conversation

stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Nov 4, 2024 •
edited
Loading

See issue #67

Compatibility processing

  • reformat compatibility message (remove colour coding of text)
  • In addition to recognizing .sbml and .sedml files as SBML and SED-ML format, .xml files with 'sedml' + 'sbml' or 'sbml' but not 'sedml' in their filename are recognized as SBML and SED-ML files. Other file types are not recognized but this can be extended in the future.
  • Instead of ❌ FAIL, unrecognized filetypes will marked as ❓UNSURE (this hasn't happened so far). At the moment all engines that do not support SBML/SED-ML are still marked as⚠ XFAIL.

Test suite

  • Updated the results table of case 00001
  • Added a table of case 01186 (steady state Flux Balance Analysis)

Add back foldout menu in Engines column (went lost with the previous PR when the engine names were reformated)

@stellaprins
draft adding list of cases to command line options
c2e1f45
@stellaprins
Merge branch 'feature/68-add-remote-links-to-results-table-and-deal-w…
6890443 
…ith-engines-that-seem-to-pass-but-have-the-wrong-results' into feature/67-update-test-suite-results
@stellaprins
update test suite 00001 table and draft for 01186 table
cce679c
@stellaprins
add sedml and sbml files of case 01186
a979a7c
@stellaprins
update ansi_to_html
1959b39
@stellaprins
remvoe test code for case handling
228eace
@stellaprins
enable processing of a given list of cases, or a limit of cases that …
58917f9 
…are processed sequentially when an empty lissed is passed
@stellaprins
correct handling of cases in proces_test_suite script
a6e7d65
@stellaprins
add full stop ad end of sentence in compatibility check messages in c…
43e2d40 
…heck_file_compatibility_test function
@stellaprins
exclude files ending with 'omex' in test suite results table
5cd0328
@stellaprins
Improve compatibility messages. When files have an .xml extension but…
744a15e 
… 'sbml' or 'sbml' and 'sedml' in the filename they can be labeled as SBML and SEDML (test suite)
@stellaprins
Merge branch 'development' into feature/67-update-test-suite-results
064ed84
@stellaprins stellaprins self-assigned this Nov 5, 2024
@stellaprins stellaprins marked this pull request as ready for review November 5, 2024 09:42
@stellaprins stellaprins marked this pull request as draft November 5, 2024 09:42
@stellaprins stellaprins requested review from robertvi and removed request for robertvi November 5, 2024 09:42
@stellaprins stellaprins marked this pull request as ready for review November 5, 2024 10:02
@stellaprins
Copy link
Collaborator Author

@robertvi I just noticed the links to the plots aren't working as expected. Will fix this in the current PR!

robertvi
robertvi requested changes Nov 8, 2024
View reviewed changes
utils/__init__.py Show resolved Hide resolved
@stellaprins stellaprins merged commit 9cd561b into development Nov 11, 2024
48 checks passed
@stellaprins stellaprins deleted the feature/67-update-test-suite-results branch November 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertvi robertvi robertvi requested changes

Assignees

@stellaprins stellaprins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellaprins @robertvi