Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sbml omv validation #113

Merged

Conversation

robertvi
Copy link
Contributor

No description provided.

@robertvi
Copy link
Contributor Author

robertvi commented Dec 12, 2023

(venv) vagrant@ubuntu-jammy:~/repos/forks/SBMLShowcase/SBML$ omv all
[omv] Python 3. Ignoring tests for non Py3 compatible engines: False
[omv]
[omv]
[omv] Running the tests defined in ./.test.validate.omt
[omv] =================================================
[omv]   No mep file specified. Will only run simulation using: pyNeuroML_validate_sbml
[omv]   Found 1 experiment(s) to run on engine: pyNeuroML_validate_sbml
[omv]   Running with pyNeuroML_validate_sbml, using: ['pynml', '-validate-sbml', '/home/vagrant/repos/forks/SBMLShowcase/SBML/LEMS_NML2_Ex9_FN.sbml', '/home/vagrant/repos/forks/SBMLShowcase/SBML/Run_Regular_HindmarshRose.sbml']...
[omv]     Running the commands: [pynml -validate-sbml /home/vagrant/repos/forks/SBMLShowcase/SBML/LEMS_NML2_Ex9_FN.sbml /home/vagrant/repos/forks/SBMLShowcase/SBML/Run_Regular_HindmarshRose.sbml] in (/home/vagrant/repos/forks/SBMLShowcase/SBML; cwd=/home/vagrant/repos/forks/SBMLShowcase/SBML; shell=False; env=None)
[omv]     Commands: ['pynml', '-validate-sbml', '/home/vagrant/repos/forks/SBMLShowcase/SBML/LEMS_NML2_Ex9_FN.sbml', '/home/vagrant/repos/forks/SBMLShowcase/SBML/Run_Regular_HindmarshRose.sbml'] completed successfully
[omv]   Running checks for experiment: Dry run
[omv]
[omv]       Observable                        Test Passed
[omv]       --------------------------------------------------
[omv]       dry                                    ✔
[omv]
[omv]
[omv]       [ Test 1 of 1 complete - failed so far: 0 ]
[omv]
[omv]                             -------------
[omv]                             1 test(s) run
[omv]                             -------------
[omv]
[omv]                           All tests passing!
[omv]                           ==================
(venv) vagrant@ubuntu-jammy:~/repos/forks/SBMLShowcase/SBML$

@pgleeson
Copy link
Member

Great. Don't forget to add the new engine here: https://github.com/OpenSourceBrain/osb-model-validation/blob/master/.github/workflows/ci.yml#L19 so it will be tested.

@robertvi robertvi marked this pull request as ready for review January 24, 2024 10:38
@pgleeson pgleeson changed the base branch from master to development January 29, 2024 10:44
@pgleeson pgleeson merged commit 72fec32 into OpenSourceBrain:development Jan 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants