Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move options.switchTpShareForDs4 check to getPS4Report() #329

Closed
bsstephan opened this issue Jun 13, 2023 · 0 comments · Fixed by #336
Closed

Move options.switchTpShareForDs4 check to getPS4Report() #329

bsstephan opened this issue Jun 13, 2023 · 0 comments · Fixed by #336
Assignees
@bsstephan

Comments

@bsstephan
Copy link
Contributor

As per ddf59c3#commitcomment-117842350, the PS4 TP/Share toggle manipulates the actual pin mapping of S1 and A2, which is going to be an issue for my hotkey PR which uses the button masks directly (and thus encapsulating the feature would mean duplicating the logic there), and I think it's misleading to other parts of the code.

After a quick Discord conversation I think we can move this check to the PS4-specific report, and then S1 always is S1.

I'll try to get to this soon, if no one beats me to it.
@bsstephan bsstephan self-assigned this Jun 13, 2023
bsstephan referenced this issue Jun 13, 2023
@arntsonl
This change did not make sense to be part of the web config modificat…
ddf59c3 
…ion.
bsstephan added a commit to bsstephan/GP2040-CE that referenced this issue Jun 14, 2023
@bsstephan
move PS4 TP/Share switch check to getPS4Report
b9a76b9 
this allows the rest of the gamepad code --- hotkeys, BOOTSEL boot
hotkey --- to always treat S1 as S1 and A2 as A2, rather than having to
also encapsulate the switch check in order to have consistent behavior.
the switch is only for PS4 mode anyway, so we can just stuff it in
there.

fixes OpenStickCommunity#329
@bsstephan bsstephan mentioned this issue Jun 14, 2023
Merged
arntsonl pushed a commit that referenced this issue Jun 14, 2023
@bsstephan
move PS4 TP/Share switch check to getPS4Report (#336)
7aa176e 
this allows the rest of the gamepad code --- hotkeys, BOOTSEL boot
hotkey --- to always treat S1 as S1 and A2 as A2, rather than having to
also encapsulate the switch check in order to have consistent behavior.
the switch is only for PS4 mode anyway, so we can just stuff it in
there.

fixes #329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsstephan bsstephan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move PS4 TP/Share switch check to getPS4Report bsstephan/GP2040-CE
1 participant
@bsstephan