HOTKEY_HOME_BUTTON doesn't do anything because I broke it #360
Comments
bsstephan
added a commit
to bsstephan/GP2040-CE
that referenced
this issue
Jun 22, 2023
the top-level check was actually somewhat redundant now that I fixed lastAction, since the toggles checked it anyway, but we can still use a similar approach to not save unless we need to. but now, we also don't interfere with e.g. HOTKEY_HOME_BUTTON, which *should* always take effect as long as the hotkey is pressed, even if we've done it in past cycles --- but it shouldn't save, so don't request it. fixes OpenStickCommunity#360
arntsonl
pushed a commit
that referenced
this issue
Jun 22, 2023
#366) don't check lastAction for non-toggle, non-save hotkey actions the top-level check was actually somewhat redundant now that I fixed lastAction, since the toggles checked it anyway, but we can still use a similar approach to not save unless we need to. but now, we also don't interfere with e.g. HOTKEY_HOME_BUTTON, which *should* always take effect as long as the hotkey is pressed, even if we've done it in past cycles --- but it shouldn't save, so don't request it. fixes #360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HOTKEY_HOME_BUTTON no longer does anything perceivable in
main, I'm pretty sure because of 9c7ed02 --- I think in reality it is actually being pressed for 1ms and then disappears.Probably what needs to happen is hotkey actions that modify
state.buttonsshouldn't be subject to theaction != lastActioncheck. This will take some rejiggering in the code.Note that this issue also blocks the fix in #342 as it also intends to set
state.buttons.The text was updated successfully, but these errors were encountered: