Update Keyboard Converter Config #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTrainGoes
requested changes
May 23, 2024
| #define USB_PERIPHERAL_PIN_ORDER 0 | ||
| #define USB_PERIPHERAL_PIN_5V -1 | ||
|
|
||
| #define HAS_I2C_DISPLAY 0 |
There was a problem hiding this comment.
Is this needed? Have you tried compiling without 68 + 69?
There was a problem hiding this comment.
Yes, when compiling and flashing without those defines, I2C0 was enabled, but had no pins set and Keyboard Host would not function until I2C0 was disabled. By explicitly disabling both, there is no need for an intermediary step of going to web config to disable them.
TheTrainGoes
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.