Add a hotkey to cycle between profiles. #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to ask that we split this into two PRs to separate contexts. Locale changes go to a separate PR from functional ones. Also, no AI translations. Thanks. |
bsstephan
requested changes
May 30, 2024
|
I have removed the localization to add to another pull request if this one is approved as requested by mikepparks and bsstephan. I have also fixed the spacing and enum issues that mikepparks brought up. I believe that resolves everything mentioned. But I'd be happy to take another look if there is anything else out of line. |
bsstephan
approved these changes
Jun 3, 2024
|
My review is satisfied, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a hotkey option called "Next Profile". When assigned and pressed cycles to the next profile so that a button doesn't need to be assigned to each profile.
For example, if on Profile 1 it changes to Profile 2, then to 3, then to 4, then back to 1.
I removed lastAction = HOTKEY_NONE; from gamepad.cpp since it is already assigned on initialization in gamepad.h and seems to only cause hotkeys that use userRequestedReinit = true; to trigger rapidly while the button is held down.
For German and Portuguese translations, I had some friends that speak those languages confirm that they are correct translations. However, I used Chat GPT to get the simplified Chinese Translation. That should be considered a placeholder until someone that knows the language can take a look at it.
Resolves #1016