I2C Autodetection #1072
Merged
I2C Autodetection #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added experimental wrapper class for ADS1219 to handle device auto-detection.
…tion rather than rely on I2C block options. Added address range to ADS1219 addon to allow scanning across full range.
…the usage of other devices on the same block.
… like Display to take full control of the bus.
arntsonl
previously approved these changes
Jul 31, 2024
arntsonl
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to reduce the amount of work needed for migration and configuration of I2C addons, this PR aims to allow all I2C addons to be autodetected on startup. This removes the need for I2C address and block fields in webconfig and subsequent configuration data. A device only needs to be included on a previously-enabled I2C peripheral block and its addon enabled.
available()is called, if the addon is enabled, the list of known I2C addresses for the device will be passed to thePeripheralManagerto be scanned.This approach does allow the autodetection of supported Display devices. However, further work will need to be done to either allow interoperability between the Display and other devices sharing the I2C block, or a "priority" mode where the block cannot be shared with others.