Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deflate compression for fsdata.c #2

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

deeebug
Copy link
Contributor

@deeebug deeebug commented Dec 8, 2022

Hi,

I've compiled new binaries for makefsdata with miniz enabled. This should significantly reduce the size of fsdata.c because this build of makefsdata uses deflate.

This reduced the size of fsdata.c from 4MB to 1MB. And that has allowed the reduction of the size of UF2s significantly!

Please verify and accept the merge if alright.

Thanks!

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should revisit how makefsdata and makefsdata.exe are built in the future from the lwip project.

@arntsonl arntsonl merged commit 2a43d06 into OpenStickCommunity:main Dec 11, 2022
@deeebug deeebug deleted the minify-fsdata_c branch December 18, 2022 10:21
@deeebug deeebug restored the minify-fsdata_c branch December 18, 2022 10:22
arntsonl added a commit that referenced this pull request Feb 13, 2023
#1 Added Fightboardv3 + mirrored to cmake.yml
#2 Removed Add-on "Enabled" by default (fixes Dual Directional reverse input)
arntsonl pushed a commit that referenced this pull request Sep 25, 2024
…display (#1139)

* add the ability to give a profile a name

* Add support for changing profile labels

* Letters, numbers, and spaces allowed in profile label

* actually retain the alt. profile labels

aka increment the array index *after* you're done using it, silly bss

* actually provide the alt mappings profileLabels in the proper API spot

this fixes the issues with Pelsin's UI change, which was immaculately
done and only thwarted by my bugs =)

* display the profile label on the display when a label is set

e.g. the top line splash says "SNES FG" instead of "Profile #2"

---------

Co-authored-by: ian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants