Storage manager optimizations #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arntsonl
approved these changes
May 3, 2023
henrebotha
pushed a commit
to henrebotha/GP2040-CE-1
that referenced
this pull request
May 3, 2023
* Build makefsdata for Linux w/ MUSL * Restored deflate support to makefsdata * WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
StorageManagerreturns its configs by value, which is unnecessary and inefficient. In particular this is a problem with the Turbo addon, which reads its config on everyprocess()call.With this PR
StorageManagerreturns configs as aconstreference. I have also moved the getters to the header so that they can be inlined by the compiler.