Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PLED_TYPE overriding LEDOptions.pledType #253

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix PLED_TYPE overriding LEDOptions.pledType #253

merged 1 commit into from
May 16, 2023

Conversation

FeralAI
Copy link
Contributor

@FeralAI FeralAI commented May 15, 2023

Missed this update when implementing the PLED configuration. Firmware was always using the PLED_TYPE instead of the configured option.

@FeralAI FeralAI requested a review from arntsonl May 15, 2023 21:26
arntsonl
arntsonl approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, move things to storagemanager.

@arntsonl arntsonl merged commit ff1470b into OpenStickCommunity:main May 16, 2023
@FeralAI FeralAI deleted the bugfix/pled-updates branch May 17, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeralAI @arntsonl