Add forced circularity option and minor fix to analog.cpp #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an analog configuration option to force perfect circularity on analog joystick. This video does a good job of showing why it should be an option - (https://www.youtube.com/watch?v=1P1mItHTKJw) Nest the deadzone if statements inside the statements where their respective axis is validated.
Add webconfig option to adjust deadzone for analog joystick Fix minimum value for adjustable shotcount on webpage to match validated range
|
Adding a couple more things to this PR Add webconfig option to adjust deadzone for analog joystick |
Forgot to remove print debugs and copy/paste
arntsonl
previously approved these changes
Jun 20, 2023
|
Looks like we had one merge conflict @NickGuyver , would you mind resolving and I'll get this merged. Thanks! |
|
Should be fixed now. |
arntsonl
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an analog configuration option to force perfect circularity on analog joystick. This video does a good job of showing why it should be an option - (https://www.youtube.com/watch?v=1P1mItHTKJw)
Nest the deadzone if statements inside the statements where their respective axis is validated.