Wii addon refactor and button/analog mapping support #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GHWT touch fret support. Added initial Wii extension hot plugging support. Fixed issue with detecting GHWT guitars. Fixed issue with guitar analog values.
…ion, default is used (implemented per-controller). Verifies calibration checksum to determine which is used.
…ice. Fixed issue where adjusted input values would overflow after calibration.
… calibration exists on device. Implemented default button mapping config in prep for web-config mapping options.
Included separation of Wii addon-specific L10n strings to Locales/en/Addons/WiiAddon.jsx
Updated documentation to remove Wii controller mapping details and add new image.
arntsonl
requested changes
Sep 8, 2023
| // unknown | ||
| } | ||
|
|
||
| #if WII_EXTENSION_DEBUG==true |
There was a problem hiding this comment.
Just for cleanliness, we'll probably want to remove this before release if you're not using it. Okay to keep it into this refactor!
…I_EXTENSION_DEBUG
Pelsin
reviewed
Sep 9, 2023
Pelsin
reviewed
Sep 9, 2023
Pelsin
reviewed
Sep 9, 2023
| @@ -43,91 +47,280 @@ export const wiiState = { | |||
| wiiExtensionSpeed: 400000, | |||
| }; | |||
|
|
|||
| const WII_EXTENSION_CONTROLS = [ | |||
There was a problem hiding this comment.
I've added ways for us to normalize formating, try running npm run format
Some have reported it not really working, but worth trying!
There was a problem hiding this comment.
I'd have to go through this manually because it breaks up formatting in a way that isn't very easy on my eyes.
Pelsin
reviewed
Sep 9, 2023
arntsonl
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes support for mapping the following extension controllers: