Implement Macro feature #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this Action run I ran into issue with setting a macro. I was able to set the Macro Pin, enable Macros, and save. However, when I set a specific macro as "Activated", it would not save and threw an error in the browser console. I've included screenshots below.
|
|
Thank you for testing! These should be fixed now. |
Add Macro Documentation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, the macro addon has been implemented and is here in this PR.
Important thing to note is that the allocated flash space has been raised from 8K to 16K.
This addon supports 6 macros with 50 input lines each which also allows for waiting before moving on to the next line. This could be updated in the future, as needed.
Room for improvement is plenty. The logic for macro itself could be significantly optimized, and is frankly dumb. Same can be said for both UI and UX. But right now where it is at seems like a good foundation.
Thanks to @TheTrainGoes and @InfraredAces for testing and feedback.
Extensive testing is still pending, so reviews are appreciated.
Closes #235.
Please review and merge, thanks!