-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement input history #602 #630
Conversation
kiralydavid
commented
Nov 18, 2023
•
edited
Loading
edited
- Added input history as a new add-on.
- You can toggle it on/off from the web-config.
- It's possible to set the length of the history string (in characters) and position it on the screen by setting the starting column and row.
This looks great! Thank you @kiralydavid I will test this out when I have some time. Are you on the Discord? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation piece looks good.
Thank you for following the template. Though, if you could include the ### Installation
header and just put "None." beneath so as to maintain consistency with the template and other documents.
A few minor adjustments I'd make, just for the sake of following the existing code patterns.
|
Code changes are looking good on my end. Nice turnaround! |
@kiralydavid Looks great! We just had a push to our i2c peripherals, could you pull latest and resolve conflicts on your end? Should be pretty straight forward, @mikepparks did a great job on the i2c stuff. |