Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement input history #602 #630

Merged
merged 8 commits into from
Nov 20, 2023

Conversation

kiralydavid
Copy link
Contributor

@kiralydavid kiralydavid commented Nov 18, 2023

  • Added input history as a new add-on.
  • You can toggle it on/off from the web-config.
  • It's possible to set the length of the history string (in characters) and position it on the screen by setting the starting column and row.

@TheTrainGoes
Copy link
Contributor

This looks great! Thank you @kiralydavid

I will test this out when I have some time. Are you on the Discord?

Copy link
Contributor

@InfraredAces InfraredAces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation piece looks good.

Thank you for following the template. Though, if you could include the ### Installation header and just put "None." beneath so as to maintain consistency with the template and other documents.

@mikepparks
Copy link
Contributor

A few minor adjustments I'd make, just for the sake of following the existing code patterns.

  • I understand the reasoning for doing it, but try to avoid changing the pattern on addon constructors. Creating the Display addon should not require the Input History addon, even if it's disabled.
  • Instead, I would suggest adding a method on the addon so we only have to attach the two addons if they're enabled. It should ultimately be optional.
  • Check the state of both Input History and Display in your available() method if the Display is not enabled. See the Wii Extension addon available() for a means of doing this.

InfraredAces
InfraredAces previously approved these changes Nov 18, 2023
@mikepparks
Copy link
Contributor

Code changes are looking good on my end. Nice turnaround!

@arntsonl
Copy link
Contributor

@kiralydavid Looks great! We just had a push to our i2c peripherals, could you pull latest and resolve conflicts on your end? Should be pretty straight forward, @mikepparks did a great job on the i2c stuff.

@arntsonl arntsonl merged commit ebd93ba into OpenStickCommunity:main Nov 20, 2023
63 checks passed
@kiralydavid kiralydavid deleted the input-history branch November 20, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants