Pin remapping in Peripheral page webconfig fixes #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also deprecates old fields replaced by peripherals, which no longer need to be touched in webconfig/be present in the website
arntsonl
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with reclaiming or reserving pins on the Pin Mappings page when configuring peripherals on the Peripherals Mapping page. This makes it so that pins can be set to unused if a peripheral (e.g. I2C0 for a disconnected display) has its pins set to "Unset", freeing up the pins for general usage on the Pin Mappings page. Vice versa is true, if pins are assigned to a peripheral, now they are properly reserved in the core pin mappings.
This also removes some deprecated code and marks the old peripheral pins, pre-manager, as deprecated.