GPIO PinXY Assignment in Board Config #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use if-else block logic instead of switch in jslider debouncer (#793) I'm not going to say we *understand* why this fixes #790, but it appears to. * Adds a "pin viewer" in pin mapping page (#794) --------- Co-authored-by: Brian S. Stephan <[email protected]> Co-authored-by: Pelsin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All pin assignments for board config are now defined as:
#define GPIO_PIN_XY GpioAction::BUTTON_XY
I also migrated over the Turbo button to our pins profile, and fixed a few spots where the defaults were set to old board config assignment.
Display will show TXY in the OLED if Turbo is on now instead of validating the turbo button, but we can revisit this.