-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GP2040-CE Input Driver system rehaul #830
Merged
arntsonl
merged 15 commits into
OpenStickCommunity:main
from
arntsonl:202400120_inputdriver_revamp
Feb 7, 2024
Merged
GP2040-CE Input Driver system rehaul #830
arntsonl
merged 15 commits into
OpenStickCommunity:main
from
arntsonl:202400120_inputdriver_revamp
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…river mode, and separates all of the individual modes out of the gamepad instance. Still tons of work to be done.
…t, added conditionals for joystick mid as we can do a GPIO read before input mode is decided... tud_init() added to driver setup to make everything work
…tsonl/GP2040-CE into 202400120_inputdriver_revamp
Small change to xbone driver to remove unused variable and set last report to 0 in initialize
arntsonl
commented
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major overhaul of the USB input driver system.
All input drivers have been moved to their own child class with GPDriver set as the parent class interface.
Why: This makes adding new systems, modifying current systems, and maintaining support WAY easier.
How: This greatly simplifies where each report, report size, update mechanism, and USB calls lives and keeps the majority of our TinyUSB host code intact.
This also moves the update, send_report, send_report_cb, and get_report logic over to the input driver to handle all of these changes. this will give the input driver more control over USB and let gp2040 main pass this along.