ADS1256 SPI analog addon #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepparks
previously approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Code checks out on my end. @FeralAI tested enough on hardware that implementation testing is good enough for me.
|
Nice, I'll do a once over but this is looking clean to me |
mikepparks
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a new addon for the ADS1256, a low noise 24-bit 8-channel Analog-to-Digital converter that communicates over SPI. This addon is modeled after the existing ADS1219 addon, so extra features like deadzone config and autocalibration are not present. This work includes:
FLOATandDOUBLEin the Protobuf implementation. The macros needed to support those data types were not present inconfig_utils.cpp.For the addons page, SPI pulls from the configured peripherals and the addon will not allow configuration if at least one SPI block is not configured, similar to the ADS1219 addon. It will also present a dropdown to select the CS pin using a combination of the selected SPI block's HW CS pin and other available pins.