Dual rotary encoder support #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently only maps to Gamepad-related items (analog sticks and triggers + d-pad) and keeps those values within range (no overflowing) * The pulses per revolution can be customized, but currently untested beyond 24PPR
…zero, no snapback.
Fixed issue where min/max ranges were only based on the first encoder options.
arntsonl
requested changes
Mar 19, 2024
www/src/Addons/Rotary.tsx
Outdated
| error={errors.encoderOnePPR} | ||
| isInvalid={errors.encoderOnePPR} | ||
| onChange={handleChange} | ||
| min={24} |
There was a problem hiding this comment.
Let's knock this down to 20 for 20 PPRs
Changed Multiplier to numeric field and range to 0.10-200x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added early support for dual quadrature rotary encoders