DDI cleanups and bugfixes #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to leave this one until after release as DDI is such a funky beast. Would also be very worth asking our users who many folks used mixed in a stick/button combo and maybe if its used by Tekken folk. |
Gamepad is buggy, and both modes don't seem to have use cases. we are soft deprecating these for the moment, only making them work like Mixed, rather than actually migrating them to a new mode, for now
I think this is just a vestige of how things used to work, it makes no discernable difference in my testing. in order to start showing my work, I also added a simple piece of documentation to describe how the modes work
this replaces the gamepad output with the DDI output (no combination or re-cleaning), which is interesting for situations like gamepad holding one axis and DDI pressing the other, letting you essentially toggle between the two axis with a press/release Fixes OpenStickCommunity#823
since DDI Override was pretty easy to bring back with the new code, we might as well just bring Gamepad Override back since it's the same logic, just flipped. added more docs while I was at it.
bsstephan
force-pushed
the
ddi-improvements-cleanups
branch
from
27d189f
to
233021f
Compare
arntsonl
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This...
preprocess()intoprocess(), and subsequently makingprocess()easier to read.2. "Soft deprecates" Combination Mode Gamepad Override, which was at best a duplicate of DDI Override with different pin mappings, but also had some logic issue somehow, so it was also buggy (see discussion in Dual Directional Input cleanups/bugfixes #725)