-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro Rewrite #922
Macro Rewrite #922
Conversation
*Total -- 6,536.44kb -> 6,081.92kb (6.95%) /configs/OpenCore0/assets/Open_Core0_LED_order.png -- 81.87kb -> 34.77kb (57.53%) /configs/OpenCore0/assets/Open_Core0_pin_mapping.png -- 79.46kb -> 34.15kb (57.02%) /configs/OpenCore0/assets/Open_Core0_layout.png -- 80.33kb -> 34.76kb (56.73%) /configs/OpenCore0/assets/Open_Core0_2.jpg -- 3,134.92kb -> 2,976.17kb (5.06%) /configs/OpenCore0/assets/Open_Core0.jpg -- 3,159.87kb -> 3,002.07kb (4.99%) Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
… same button twice (web-config restricted only)
Reduced the new heap space significantly from display. Fixed up input macros to not rely on C++11 bindings. Moved storagemanager init to its own function (no longer rely on static new creation)
Display test
Merging in main
…ofile change), updated config proto to deprecated pin types, fixed bug in webconfig
Fixing up last bits of merge
…lag no longer relevant with GPIO pin mappings
…ould randomly pull from memory and try to use preview display which wasn't set on non-config modes. Strange bug, works well now!
…GP2040-CE into 20240323_macro_rewrite
…nfigmode() Going back from button layout in config successfully goes back
…prevent the memory from ever being copied outside of button layout screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes for Macro including display updates and some logic additions
Hi, I'm not sure if this is intended, but it seems that
|
I would propose that style and code consistency issues would be best left to the team to decide/act on. Good feedback but whether it gets changed or not is undecided. |
This is a rewrite of our macro system.
This moves our macro pins over to the Pin Manager panel, including our Macro Button for holding Macro + Gamepad button inputs.
The Macro page has been rewritten to use tabs instead of a large list.
Macro CSS has been cleaned up to follow proper d-flex and formatting.
Lots of other changes, but functionality should be the same as before but with Pin Mapping involved.