Macro Restart and UI Fixes #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro logic was processing macro inputs into gamepad state prior to checking if the macro needed to be reset. This resulted in repeating macros missing applying gamepad state at the end of the macro. Swapping the check for resetting the macro to before the gamepad inputs are applied and creating a
restart()method solves this issue.Also fixed an issue on the macro config page when adding and deleting macro actions. The deleted lines weren't being filtered out, causing no console errors but preventing any changes to the macro actions array. Fixed up the React key errors in the console for this page as well.
Addresses #975 & #976