Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar cleanup and enable mobile menu #989

Merged
merged 3 commits into from
May 3, 2024

Conversation

FeralAI
Copy link
Contributor

@FeralAI FeralAI commented Apr 27, 2024

This PR tightens up the navbar styling and spacing, and also enables the use of the collapsed nav for mobile when screen is less than 768px.

Summary of changes:

  • Updated logo and made that the brand icon/area of the navbar, logo file slightly smaller now.
  • Removed Home menu option and rolled that into the logo.
  • Slightly reorganized the navbar actions (language, theme, etc.)
  • Removed the inline styles on the navbar actions and used a parent container style for alignment
  • Default the nav dropdowns to open toward the right to remain visible on smaller screens, since they're pinned to that side of the screen
  • Removed the Danger Zone button. As much as I'm going to miss that remanant of the past, I think it caused more confusion than good. This has been rolled into the end of the Configuration menu
  • Renamed a few button labels to reduce space taken: Nintendo Switch is now Switch, DirectInput is now DInput.

Here's a comparison of the extended menu view:

OLD:
image

NEW:
image

The old mobile view for the menu would make all the nav list items disappear:

image

This is fixed and the hamburger menu icon will now appear:

image

And here's a preview of the expanded mobile nav:

image

There are probably some minor things to address going forward, but those can be taken care when we address the responsiveness of the page content.

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean changes and easy wins

@arntsonl arntsonl merged commit 8c4a76c into OpenStickCommunity:main May 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants