Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for building on windows #47

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fixes for building on windows #47

merged 1 commit into from
Mar 24, 2023

Conversation

BadSingleton
Copy link
Contributor

Don't link to pthread on windows

Define a symbol instead of an int, MVSC can't see it as a constant (and gives an error).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: BadSingleton / name: Félix Bourbonnais (bcdf0b6)

@meshula meshula added bug Something isn't working build labels Feb 28, 2023
@meshula
Copy link
Member

meshula commented Feb 28, 2023

Thanks for spotting those issues!

@BadSingleton
Copy link
Contributor Author

Sorry, it's going to take a while. Legal got back to us and the person that can sign the CLA is currently on holiday.

@BadSingleton
Fixes for building on windows
eb2ac08 
Don't link to pthread on windows
Define a symbol instead of an int, MVSC can't see it as a constant.

Signed-off-by: Félix Bourbonnais <[email protected]>
@BadSingleton
Copy link
Contributor Author

@meshula CLA is now signed!

@meshula
Copy link
Member

meshula commented Mar 20, 2023

Thanks!

@BadSingleton
Copy link
Contributor Author

I can repro the same CI failure on the main branch, using Ubuntu 22.04 (which looks like to be ubuntu-latest according to github), but everything is fine on Ubuntu 20.04 (and also builds fine on win10 and macos 10.15 on our side).

@meshula
Copy link
Member

meshula commented Mar 23, 2023

The build failure is clearly unrelated. I'm inclined to land it.

If you have repro, are you able to tell what the issue is? Does the OTIO_API macro need some help?

@BadSingleton
Copy link
Contributor Author

BadSingleton commented Mar 23, 2023 •
edited
Loading

Sorry, I have no idea how to fix it nor to tell what exactly the problem is (other than obviously being a linkage issue)

@meshula
Copy link
Member

meshula commented Mar 24, 2023

Ok, cool. I just double checked, the CI has been broken for nearly a year, this isn't by any means a new issue.

@meshula meshula merged commit 72bdee3 into OpenTimelineIO:main Mar 24, 2023
BadSingleton added a commit to Unity-Technologies/OpenTimelineIO-C-Bindings that referenced this pull request May 12, 2023
@BadSingleton
Fixes for building on windows (OpenTimelineIO#47)
8d3ac33 
Don't link to pthread on windows
Define a symbol instead of an int, MVSC can't see it as a constant.

Signed-off-by: Félix Bourbonnais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshula meshula meshula left review comments

@mjmvisser mjmvisser mjmvisser left review comments

Assignees
No one assigned
Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BadSingleton @meshula @mjmvisser