Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenTimelineIO from 23ff3f9 to 7302ff1 #44

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 26, 2024

Bumps OpenTimelineIO from 23ff3f9 to 7302ff1.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jan 26, 2024
@meshula
Copy link
Member

meshula commented Jan 30, 2024

Does anyone know if this is an automation problem?

/Users/runner/work/OpenTimelineIO-Swift-Bindings/OpenTimelineIO-Swift-Bindings/.build/x86_64-apple-macosx/debug/OpenTimelineIO_CXX.build/OpenTimelineIOConfig.cmake.in.o
error: unable to open dependencies file (/Users/runner/work/OpenTimelineIO-Swift-Bindings/OpenTimelineIO-Swift-Bindings/.build/x[86](https://github.com/usd-wg/assets/actions/runs/7657833293/job/20869442658?pr=72

@jminor
Copy link
Member

jminor commented Jan 30, 2024

It builds fine locally. See here: #45

@meshula
Copy link
Member

meshula commented Jan 30, 2024

Thanks, I missed that it was the same issue.

@jminor
Copy link
Member

jminor commented Feb 6, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jminor
Copy link
Member

jminor commented Feb 6, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2024

Dependabot attempted to update this pull request, but because the branch dependabot/submodules/OpenTimelineIO-7302ff1 is protected it was unable to do so.

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2024

Oh no! Something went wrong on our end. Please try again later.

If the problem persists, please contact GitHub support for assistance 🙇

@jminor
Copy link
Member

jminor commented Feb 6, 2024

It's okay, @dependabot - I think we should all get some rest and try again tomorrow.

@jminor
Copy link
Member

jminor commented Feb 6, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/submodules/OpenTimelineIO-7302ff1 branch from 796550d to 6918c25 Compare February 6, 2024 20:21
@jminor
Copy link
Member

jminor commented Feb 6, 2024

For clarity, I read the docs on how branch protection rules work, and made a new rule just for this one specific branch which allows force push and deletion. That seems to have allowed dependabot to do its "recreate" action. 🤞

@jminor
Copy link
Member

jminor commented Feb 6, 2024

Sadly, this is still failing with the following error:

error: unable to open dependencies file (/Users/runner/work/OpenTimelineIO-Swift-Bindings/OpenTimelineIO-Swift-Bindings/.build/x86_64-apple-macosx/debug/OpenTimelineIO_CXX.build/OpenTimelineIOConfig.cmake.in.d)

It looks like #47 didn't work 😞

@Jameclarke
Copy link
Contributor

I noticed that when pulling the latest Swift Bindings it pulls in the OpenTimelineIO branch 23ff3f9 This branch does not have reference of OpenTimeConfig.cmake.in or OpenTimelineIOConfig.cmake.in These files do exist in the OpenTimelineIO branch 7302ff1 This might be why the dependabot is failing. I made a new pull request removing the previous changes in the SPM. Thoughts? Suggestions?

@meshula
Copy link
Member

meshula commented Feb 9, 2024

Hi @Jameclarke your PR looks promising. Did you have a chance to think about @jminor's question on that PR, or was it answered somewhere? I'm inclined to land that PR, but was waiting until Josh's question was resolved.

@Jameclarke
Copy link
Contributor

@meshula I just pushed a new commit and answered Josh's question. Thank you.

@jminor
Copy link
Member

jminor commented Feb 11, 2024

@dependabot recreate

Bumps [OpenTimelineIO](https://github.com/PixarAnimationStudios/OpenTimelineIO) from `23ff3f9` to `7302ff1`.
- [Release notes](https://github.com/PixarAnimationStudios/OpenTimelineIO/releases)
- [Commits](AcademySoftwareFoundation/OpenTimelineIO@23ff3f9...7302ff1)

---
updated-dependencies:
- dependency-name: OpenTimelineIO
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/submodules/OpenTimelineIO-7302ff1 branch from 6918c25 to 5a8a782 Compare February 11, 2024 06:28
@jminor
Copy link
Member

jminor commented Feb 11, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jminor jminor merged commit 10973f2 into main Feb 11, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/submodules/OpenTimelineIO-7302ff1 branch February 11, 2024 06:32
@meshula
Copy link
Member

meshula commented Feb 12, 2024

Everything works again, phew!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants