-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support swift 5.9 with minimum 5.5 compatibility. #61
Open
furby-tm
wants to merge
9
commits into
OpenTimelineIO:main
Choose a base branch
from
wabiverse:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: furby™ <[email protected]>
Noted by @jchen9 - this is likely necessary to use the cross-platform (Linux included) This version bump is required to be able to begin deprecating the Objective-C bindings and support Swift/C++ interop, and making this Swift Package available for the Linux platform, immediately this change should now allow us to support visionOS. |
jminor
approved these changes
Oct 1, 2024
* note: this only applies to the OpenTimelineIO_CXX import, OpenTime_CXX has no issues importing as-is. Signed-off-by: furby™ <[email protected]>
Signed-off-by: furby™ <[email protected]>
* This target does not yet support the fuller OpenTimelineIO API. * This target should work cross-platform (on Linux, macOS, & Windows), since it uses Swift/C++ interop, without any objc dependencies. Signed-off-by: furby™ <[email protected]>
Signed-off-by: furby™ <[email protected]>
Signed-off-by: furby™ <[email protected]>
Signed-off-by: furby™ <[email protected]>
Signed-off-by: furby™ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Support Swift 5.9, visionOS 1.0+, and a minimum iOS version of 12.
Add a list of changes, and note any that might need special attention during review.
Reference associated tests.