Cmake: build .app bundle on macOS, added OTIO icon #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Lehr <[email protected]>
jminor
requested changes
May 22, 2024
| @@ -5,7 +5,24 @@ project(raven VERSION 1.0) | |||
|
|
|||
| set(CMAKE_OSX_ARCHITECTURES "arm64;x86_64") | |||
|
|
|||
| add_executable(raven) | |||
| if(APPLE) | |||
| set(APP_BUNDLE_IDENTIFIER "com.opentimelineio.raven") | |||
There was a problem hiding this comment.
We have opentimeline.io but not opentimelineio.com domain. So this could be io.opentimeline.raven
|
@jminor We are using it on our end, but I didn't think about stuff like the domain, bundle name, proper icon ... Did you build it and have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily for reference: This change configures cmake to build an .app bundle for Raven and adds the OTIO icon as a temporary icon for the bundle.