Add drag and drop support for Windows #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Wilshaw <[email protected]>
ThomasWilshaw
force-pushed
the
dragndrop_windows
branch
from
16863e5
to
e4280bd
Compare
meshula
reviewed
Nov 5, 2024
| file_list[i] = (char*)malloc(MAX_PATH * sizeof(char)); | ||
| strcpy_s(file_list[i],MAX_PATH, temp_filename); | ||
| } | ||
|
|
There was a problem hiding this comment.
the guts here become slightly more complex
if (DragQueryFileW(hDrop, i, temp_filename, MAX_PATH)) {
// Determine the required buffer size for the multi-byte string
int buffer_size = WideCharToMultiByte(CP_UTF8, 0, temp_filename, -1, NULL, 0, NULL, NULL);
// Allocate memory for the converted file name
file_list[i] = (char*)malloc(buffer_size * sizeof(char));
// Convert wide character filename to UTF-8
WideCharToMultiByte(CP_UTF8, 0, temp_filename, -1, file_list[i], buffer_size, NULL, NULL);
}
meshula
reviewed
Nov 5, 2024
| char** file_list; | ||
| file_list = (char**)malloc(count * sizeof(char*)); | ||
| char temp_filename[MAX_PATH]; | ||
|
|
There was a problem hiding this comment.
add
wchar_t temp_filename[MAX_PATH];
meshula
requested changes
Nov 5, 2024
| break; | ||
| case WM_DROPFILES: | ||
| HDROP hDrop = reinterpret_cast<HDROP>(wParam); | ||
| UINT count = DragQueryFileA(hDrop, -1, NULL, 0); |
There was a problem hiding this comment.
could we switch this to W please, and the char** to wchar_t** as necessary? I haven't check the rest of main to find out if there's more ANSI to WIDE conversion necessary, but we could start here.
There was a problem hiding this comment.
Both src/opentimelineio/serialization.cpp and src/opentimelineio/deserialization.cpp use MultiByteToWideChar() for opening files.
There was a problem hiding this comment.
Am I right in thinking file_list should remain as char as we're converting UTF characters in temp_filename into chars with WideCharToMultiByte?
Signed-off-by: Thomas Wilshaw <[email protected]>
ThomasWilshaw
force-pushed
the
dragndrop_windows
branch
from
35c547f
to
7e431a0
Compare
Signed-off-by: Thomas Wilshaw <[email protected]>
Signed-off-by: Thomas Wilshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #57 I've added drag and drop support for Windows. It seems to work okay on basic testing but I'm always a bit iffy about C pointers so please let me know if I've messed something up there.
If you drag a single file it loads correctly but if you drag several it triggers the existing code path for loading multiple files so any changes to that should work as expected on Windows