-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor Voter application layout #619
Open
gogarufi
wants to merge
7
commits into
main
Choose a base branch
from
refactoring/svelte-layouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e18121 - Browse repository at this point
Copy the full SHA 1e18121View commit details -
refactor: remove populate restrictions from settings types
Removes the ACL populate restrictions from `App Settings` and `App Customization` content types. They are not needed for security, because the types do not contain relations. Having them needlessly complicates adding new settings, because each component needs to be explicitly allowed to be populated.
Configuration menu - View commit details
-
Copy full SHA for 84cb7a9 - Browse repository at this point
Copy the full SHA 84cb7a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16abbfe - Browse repository at this point
Copy the full SHA 16abbfeView commit details
Commits on Oct 22, 2024
-
fix: typing and null checks for
App Settings
in StrapiAdd proper typing to the Strapi functions handling `DynamicSettings` and add null checks to prevent errors if the initial `App Settings` object was not created correctly.
Configuration menu - View commit details
-
Copy full SHA for 6a58d6b - Browse repository at this point
Copy the full SHA 6a58d6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce065e - Browse repository at this point
Copy the full SHA 5ce065eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de1ffa - Browse repository at this point
Copy the full SHA 6de1ffaView commit details -
tmp: stacked context for page styles
A PoC of the stacked context paradigm where any edits are reset by the consuming component’s `onDestroy` lifecycle hook. The example sets the page background using both `+page`s and `+layout`s: 1. /(voters)/+layout: init the context with default bg-base-100 2. /(voters)/+page: base-300 for the front page 3. /questions/+layout: base-300 for the whole questions route 4. /questions/[categoryId]/+page base-100 for just the category intro pages 5. /(voters)/results/[entityType]/[entityId]/+page base-300 for the entity detail page NB. Ultimately, we would init the context in `/+layout` but we're making changes now only to the Voter App.
Configuration menu - View commit details
-
Copy full SHA for 319e0c7 - Browse repository at this point
Copy the full SHA 319e0c7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.