Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor Voter application layout #619

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Oct 20, 2024

  1. Refactor Voter application.

    gogarufi committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1e18121 View commit details
    Browse the repository at this point in the history
  2. refactor: remove populate restrictions from settings types

    Removes the ACL populate restrictions from `App Settings` and `App
    Customization` content types. They are not needed for security, because
    the types do not contain relations. Having them needlessly
    complicates adding new settings, because each component needs to be
    explicitly allowed to be populated.
    kaljarv authored and gogarufi committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    84cb7a9 View commit details
    Browse the repository at this point in the history
  3. tmp: settings for header styling

    kaljarv authored and gogarufi committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    16abbfe View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix: typing and null checks for App Settings in Strapi

    Add proper typing to the Strapi functions handling `DynamicSettings` and
    add null checks to prevent errors if the initial `App Settings` object
    was not created correctly.
    kaljarv committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6a58d6b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ce065e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6de1ffa View commit details
    Browse the repository at this point in the history
  4. tmp: stacked context for page styles

    A PoC of the stacked context paradigm where any edits are reset by the
    consuming component’s `onDestroy` lifecycle hook.
    
    The example sets the page background using both `+page`s and `+layout`s:
    
    1. /(voters)/+layout: init the context with default bg-base-100
    2. /(voters)/+page: base-300 for the front page
    3. /questions/+layout: base-300 for the whole questions route
    4. /questions/[categoryId]/+page base-100 for just the category intro
       pages
    5. /(voters)/results/[entityType]/[entityId]/+page base-300 for the
       entity detail page
    
    NB. Ultimately, we would init the context in `/+layout` but we're
    making changes now only to the Voter App.
    kaljarv committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    319e0c7 View commit details
    Browse the repository at this point in the history