easyrsa_mkdir(): Remove use of 'mkdir -p', use only 'mkdir' #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinCanTech
force-pushed
the
replace-easyrsa-mkdir-p
branch
2 times, most recently
from
bbe8688
to
094cb08
Compare
Windows 11 fails to execute 'mkdir.exe -p $foo' and fails to return an error. easyrsa_mkdir() is a simple wrapper function for 'mkdir', which specifically checks that the requested directory is created, without relying on the exit status of 'mkdir.exe'. easyrsa_mkdir() does not support the '-p' (Parent) switch. Instead, `easyrsa` is tasked with creating the parent dirs as required. The old easyrsa_mkdir_p() is removed and replaced. This is not a fix for Windows 11, it is addressing a known issue by ensuring the failure is captured correctly. Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech
force-pushed
the
replace-easyrsa-mkdir-p
branch
from
094cb08
to
39ef535
Compare
Re. Windows 11; remove untested instructions related to non-admin mode. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 11 fails to execute 'mkdir.exe -p $foo' and fails to return an error.
easyrsa_mkdir() is a simple wrapper function for 'mkdir', which specifically checks that the requested directory is created, without relying on the exit status of 'mkdir.exe'.
easyrsa_mkdir() does not support the '-p' (Parent) switch. Instead,
easyrsais tasked with creating the parent dirs as required.The old easyrsa_mkdir_p() is removed and replaced.
This is not a fix for Windows 11, it is addressing a known issue by ensuring the failure is captured correctly.