Remove all prerequisite code to build a safe SSL config file #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code being removed was used to always build a safe SSL config file during 'init-pki' and before running most other commands. The reason for this code was because LibreSSL throws an error for missing config file when generating random numbers. The first part of the change here is to redirect LibreSSL error-out to '/dev/null', when generating random numbers, and only capture the random number that is generated. The second part is to remove all the code that built a safe SSL config file prior to running all commands, so that a safe SSL config was always present in the PKI. This is no longer required. The third part is to improve and document command 'make-safe-ssl'. The final result is that 'easyrsa_openssl()' is used as required, to build a safe SSL config file on demand, as was the original design. Signed-off-by: Richard T Bonhomme <[email protected]>
|
Applies-to: #749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code being removed was used to always build a safe SSL config file during 'init-pki' and before running most other commands. The reason for this code was because LibreSSL throws an error for missing config file when generating random numbers.
The first part of the change here is to redirect LibreSSL error-out to '/dev/null', when generating random numbers, and only capture the random number that is generated.
The second part is to remove all the code that built a safe SSL config file prior to running all commands, so that a safe SSL config was always present in the PKI. This is no longer required.
The third part is to improve and document command 'make-safe-ssl'.
The final result is that 'easyrsa_openssl()' is used as required, to build a safe SSL config file on demand, as was the original design.
Signed-off-by: Richard T Bonhomme [email protected]