Update EventScheduler init for backwards-compat. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test coverage for started state after init
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #46 +/- ##
==========================================
+ Coverage 49.11% 53.41% +4.29%
==========================================
Files 14 14
Lines 1189 1084 -105
==========================================
- Hits 584 579 -5
+ Misses 605 505 -100
☔ View full report in Codecov by Sentry. |
ChanceNCounter
approved these changes
Aug 29, 2023
ChanceNCounter
approved these changes
Aug 29, 2023
JarbasAl
reviewed
Aug 29, 2023
ChanceNCounter
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scheduler init to wait for thread start for test compat.
Add unit test coverage for started state after init
Followup to #45
Resolves OpenVoiceOS/ovos-core#342
Validated https://github.com/OpenVoiceOS/ovos-core/actions/runs/6016994283/job/16322198179?pr=339