Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/session_per_bus_connection #50

Merged
merged 15 commits into from
Sep 29, 2023
Merged

feat/session_per_bus_connection #50

merged 15 commits into from
Sep 29, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 27, 2023

deterministic default session to properly support containers and other distributed setups

allow passing a Session in the bus client constructor

default session exclusively managed by ovos-core

NOTE: things such as hivemind clients that want isolation now need to explicitly request their own session by passing it to the bus constructor

more info here OpenVoiceOS/ovos-core#354

@JarbasAl JarbasAl changed the title fix/ensure same session is always used feat/session_per_bus_connection Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (416f0b2) 53.49% compared to head (e7e4aaa) 54.58%.
Report is 2 commits behind head on dev.

❗ Current head e7e4aaa differs from pull request most recent head 4b76f5c. Consider uploading reports for the commit 4b76f5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #50      +/-   ##
==========================================
+ Coverage   53.49%   54.58%   +1.08%     
==========================================
  Files          14       14              
  Lines        1086     1090       +4     
==========================================
+ Hits          581      595      +14     
+ Misses        505      495      -10     
Files Coverage Δ
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/client/client.py 34.11% <31.25%> (+0.61%) ⬆️
ovos_bus_client/session.py 59.92% <59.37%> (+5.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

to properly support containers and other distributed setups
@JarbasAl JarbasAl added the enhancement New feature or request label Sep 27, 2023
@JarbasAl JarbasAl marked this pull request as draft September 27, 2023 20:22
JarbasAl added a commit to OpenVoiceOS/ovos-core that referenced this pull request Sep 27, 2023
@JarbasAl JarbasAl added the bug Something isn't working label Sep 27, 2023
JarbasAl added a commit to JarbasHiveMind/hivemind-websocket-client that referenced this pull request Sep 27, 2023
@JarbasAl JarbasAl removed the bug Something isn't working label Sep 29, 2023
@JarbasAl JarbasAl marked this pull request as ready for review September 29, 2023 15:58
@JarbasAl JarbasAl merged commit 9b0f422 into dev Sep 29, 2023
6 checks passed
@JarbasAl JarbasAl deleted the fix/reuse_session branch September 29, 2023 16:11
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant