-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/session_per_bus_connection #50
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #50 +/- ##
==========================================
+ Coverage 53.49% 54.58% +1.08%
==========================================
Files 14 14
Lines 1086 1090 +4
==========================================
+ Hits 581 595 +14
+ Misses 505 495 -10
☔ View full report in Codecov by Sentry. |
to properly support containers and other distributed setups
deterministic default session to properly support containers and other distributed setups
allow passing a Session in the bus client constructor
default session exclusively managed by ovos-core
NOTE: things such as hivemind clients that want isolation now need to explicitly request their own session by passing it to the bus constructor
more info here OpenVoiceOS/ovos-core#354