Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple concerns from bus/workshop #205

Closed
JarbasAl opened this issue Dec 28, 2023 · 1 comment
Closed

decouple concerns from bus/workshop #205

JarbasAl opened this issue Dec 28, 2023 · 1 comment
Assignees
@emphasize @JarbasAl @NeonDaniel
Labels
packaging refactor code improvements with no functional changes

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Dec 28, 2023 •
edited
Loading

this module started as common utils for mycroft-core , nowadays it does some things that belong to other modules

packaging problems:

  • every other ovos package depends on utils, utils can not depend on any other ovos package
  • some utils need ovos-config, this is usually handled by falling back to a default value
  • some utils need a bus connection, FakeBus is a possibility for mocking but realistically none of this code can be used without ovos-bus-client

proposal:

  • move common bus api wrappers to ovos-bus-client or ovos-workshop
  • remove dead code 0.1.0 alpha 1 #204

Consuming services via bus -> ovos-bus-client :

Providing services via bus -> ovos-workshop :

Other utils

  • skill directories related to loading skill entrypoints/paths and depends on OPM -> ovos-plugin-manager
  • mark1 should become part of the phal plugin, keep all mark1 related code there
@JarbasAl JarbasAl added refactor code improvements with no functional changes packaging labels Dec 28, 2023
@JarbasAl
Copy link
Member Author

on further analysis, ConverseTracker should be deprecated as it was a workaround for mycroft-core limitations

IntentQuery should also not be added to other package as the intent pipelines roadmapped for 0.0.9 will change that api so it is also marked for deprecation/big_rewrite

JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this issue Dec 28, 2023
@JarbasAl
feat/bus_apis
8fd07e2 
companion to OpenVoiceOS/ovos-utils#205
This was referenced Dec 28, 2023
Merged
Merged
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this issue Dec 28, 2023
@JarbasAl
feat/bus_apis (#66)
01ffd21 
companion to OpenVoiceOS/ovos-utils#205
@JarbasAl JarbasAl mentioned this issue Dec 28, 2023
Closed
15 tasks
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this issue Dec 28, 2023
@JarbasAl
refactor/move_from_utils
41d73ab 
OpenVoiceOS/ovos-utils#205
@JarbasAl JarbasAl mentioned this issue Dec 28, 2023
Merged
JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this issue Dec 28, 2023
@JarbasAl
refactor/move_from_utils
91cb522 
OpenVoiceOS/ovos-utils#205
@JarbasAl JarbasAl mentioned this issue Dec 28, 2023
Merged
JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this issue Dec 28, 2023
@JarbasAl
refactor/move_from_utils (#196)
e81677f 
OpenVoiceOS/ovos-utils#205
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this issue Dec 28, 2023
@JarbasAl
refactor/move_from_utils (#153)
308ff2d 
* refactor/move_from_utils

OpenVoiceOS/ovos-utils#205

* update imports

* update imports

* tests
@JarbasAl JarbasAl mentioned this issue Dec 28, 2023
Merged
@github-actions github-actions bot mentioned this issue Dec 28, 2023
Merged
JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this issue Dec 29, 2023
@JarbasAl
update imports (#198)
5430e55 
* refactor/move_from_utils

OpenVoiceOS/ovos-utils#205

* update imports for latest utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emphasize emphasize

@JarbasAl JarbasAl

@NeonDaniel NeonDaniel

Labels
packaging refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emphasize @JarbasAl @NeonDaniel