Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Option.when instead of ifelse or OptionWrapper #3576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use Option.when instead of ifelse or OptionWrapper #3576

wants to merge 1 commit into from

Conversation

Tang-Haojin
Copy link
Member

No description provided.

eastonman
eastonman approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tang-Haojin Tang-Haojin mentioned this pull request Sep 14, 2024
Merged
poemonsense
poemonsense approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dalao

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 3ee3246

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
3ee3246 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
8e93c8f 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
093b2fc 1.865 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.423 3.212
0c658d9 0.450 2.695 1.186 2.400 0.919 1.397 3.415 2.747 3.212
0345934 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
63d67ef 1.865 2.695 1.186 2.832 2.488 0.919 1.397 1.454 3.415 2.423 3.212
e9f7c49 1.865 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
7acf8b7 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosscharlie bosscharlie bosscharlie approved these changes

@weidingliu weidingliu weidingliu approved these changes

@huxuan0307 huxuan0307 huxuan0307 approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@cebarobot cebarobot cebarobot approved these changes

@ngc7331 ngc7331 ngc7331 approved these changes

@eastonman eastonman eastonman approved these changes

@poemonsense poemonsense poemonsense approved these changes

@Ivyfeather Ivyfeather Awaiting requested review from Ivyfeather Ivyfeather is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

@Lemover Lemover Awaiting requested review from Lemover Lemover is a code owner

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx is a code owner

@Gao-Zeyu Gao-Zeyu Awaiting requested review from Gao-Zeyu Gao-Zeyu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Tang-Haojin @XiangShanRobot @poemonsense @eastonman @ngc7331 @cebarobot @linjuanZ @huxuan0307 @weidingliu @bosscharlie