Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bpu: Optimize CGE of bpu/predictors_io_update #3579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bpu: Optimize CGE of bpu/predictors_io_update #3579

wants to merge 2 commits into from

Conversation

Lawrence-ID
Copy link
Collaborator

Bpu: Optimize CGE of bpu/predictors_io_update by moving update regs into predictors, except for the update PC

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0320241

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0320241 1.865 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0c658d9 0.450 2.695 1.186 2.400 0.919 1.397 2.747 3.212
0345934 0.450 2.695 1.186 2.400 0.919 1.397 1.454 3.415 2.747 3.212
63d67ef 1.865 2.695 1.186 2.832 2.488 0.919 1.397 1.454 3.415 2.423 3.212
e9f7c49 1.865 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
7acf8b7 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
78a6e80 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
ecdd929 1.855 0.450 2.695 1.186 2.822 2.490 2.400 0.919 1.397 1.454 3.362 2.756 2.418 3.212
cdb8dc6 1.865 0.450 2.695 1.186 2.822 2.490 2.400 0.919 1.397 1.454 3.362 2.756 2.418 3.212

Lingrui98
Lingrui98 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Lingrui98 Lingrui98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pc field of update bundle and other update data are not in the same stage, would be better if add some comments to mark that information

@Lawrence-ID Lawrence-ID added the do not merge Do not merge this pull request label Sep 19, 2024
@Lawrence-ID
chore: add some comments
c0bf3f4 
pc field of update bundle and other update data are not in the same stage
@Lawrence-ID Lawrence-ID added power about power design or optimization and removed do not merge Do not merge this pull request labels Oct 28, 2024
eastonman
eastonman requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be rebased to master branch.

@eastonman eastonman mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lingrui98 Lingrui98 Lingrui98 left review comments

@eastonman eastonman eastonman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
power about power design or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lawrence-ID @XiangShanRobot @eastonman @Lingrui98