Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodule(CoupledL2): Fix DataStorage en signal #3656

Closed
wants to merge 2 commits into from
Closed

Conversation

Ivyfeather
Copy link
Member

@Ivyfeather Ivyfeather commented Sep 26, 2024

In previous design, task_s3_valid_hold2(1) will change during the two cycles,
so it is inproper to use task_s3_valid_hold2.orR as req_valid.
Instead, we just use (0) as req_valid, which is guaranteed to keep unchanged.

@Ivyfeather Ivyfeather changed the title submodule(CoupledL2): Fix DataStorage en and add check Assertions submodule(CoupledL2): Fix DataStorage en signal Sep 27, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: f351a10

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
f351a10 1.934 0.451 2.704 1.194 2.812 2.465 2.403 0.913 1.401 1.626 3.421 2.743 2.429 3.271

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
97e37a2 1.934 0.451 2.704 1.194 2.812 2.465 2.402 0.913 1.401 1.626 3.415 2.743 2.429 3.271
d275ad0 1.934 0.451 2.704 1.194 2.812 2.465 2.401 0.913 1.401 1.626 3.421 2.743 2.429 3.271
979d98a 0.451 2.704 2.400 0.913 1.401 2.743
7543e8e 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.415 2.743 2.429 3.271
46e9ee7 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.421 2.743 2.429 3.271
bbaa6b7 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.421 2.743 2.429 3.271
4446722 1.934 0.451 2.704 1.194 2.812 2.465 2.402 0.913 1.401 1.626 3.421 2.743 2.429 3.271
e2216ec 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.415 2.743 2.429 3.271
65b2b1e 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.415 2.743 2.429 3.271

@Ivyfeather
Copy link
Member Author

Updated by a later bump of CPL2

@Ivyfeather Ivyfeather closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants