Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling createScene returns an error saying 'requires 2 parameters' #152

Closed
CenturionD opened this issue Mar 19, 2017 · 2 comments
Closed

Comments

@CenturionD
Copy link

CenturionD commented Mar 19, 2017

https://github.com/OpenZWave/node-openzwave-shared/blob/master/src/openzwave-scenes.cc#L31

In the file openzwave-scene.cc
NAN_METHOD(OZW::CreateScene) { Nan::HandleScope scope; CheckMinArgs(2, "label"); std::string label = (*String::Utf8Value(info[0]->ToString())); SceneInfo *scene;

The CheckMinArgs number should be 1, not 2.

Workaround for those who have this issue:

zwave.createScene('example name', 'example name');

@ekarak
Copy link
Member

ekarak commented Apr 5, 2017

thanks for the bug report.

ekarak added a commit that referenced this issue Apr 5, 2017
@ekarak
Copy link
Member

ekarak commented Apr 5, 2017

I've released version 1.3.3 with this fix, please update.

@ekarak ekarak closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants