common identifier name for node ids

[jbaron]

Been using this library for a few weeks now and it is working nicely, so thanks a lot. Not a single crash so far my dev machine (although to be fair I am only using basic features).

One thing I noticed is that when I get a value the node identifier is called node_id. However when I want to set a value I have to use nodeid (so without the underscore). This makes reuse of the previous received data just that bit harder.

I know it can be fixed easily in "getZwaveValueID", but I was just wondering if there is a reason for this?

P.S Since I'm using it in a TypeScript environment, I also start creating a declaration file so it I have some type checking in place. Will share this file once in a decent shape.

[ekarak]

you're right, I'll fix this inconsistency.

[ekarak]

Hello all,
I've just pushed a fix in a new bugfix branch. Can you all please download this branch and test it?
Apologies again, this all was due to a silly typo (I was checking for 'nodeid' object property, not the correct 'node_id').

Thanks!

[jbaron]

That is a really quick fix, thanks a lot!!!

[jbaron]

Compiled it and seems to be working fine. I did however notice a difference at startup (scanning phase). My previous version of open-zwave-shared showed also all the configuration commands as "value add".

Now however I only see values of the active sensor. Has somehow this behaviour changed (I think my previous version was already month old)?

[ekarak]

The node.js plugin does not filter or alter the events raised by the
underlying c++ library. Have you updated your Openzwave sources perhaps?
Στις 7 Φεβ 2016 12:57 μ.μ., ο χρήστης "Peter" [email protected]
έγραψε:

Compiled it and seems to be working fine. I did however notice a
difference at startup (scanning phase). My previous version of
open-zwave-shared showed also all the configuration commands as "value add".

Now however I only see values of the active sensor. Has somehow this
behaviour changed (I think my previous version was already month old)?

—
Reply to this email directly or view it on GitHub.

[jbaron]

Just figured out the underlying issue (open-zwave still has still many mysteries to me ;).

The zwave config file (the xml one) from my previous version has all the command classes in there because when I added my device it broadcasted all its command classes at that time and open-wave stored that info in the XML file. This new node-wave-shared version does’t know of that and created a fresh also empty XML file. So I copied over the old config file and everything is fine again.

— Peter

On 07 Feb 2016, at 12:03, Elias Karakoulakis [email protected] wrote:

The node.js plugin does not filter or alter the events raised by the
underlying c++ library. Have you updated your Openzwave sources perhaps?
Στις 7 Φεβ 2016 12:57 μ.μ., ο χρήστης "Peter" [email protected]
έγραψε:

Compiled it and seems to be working fine. I did however notice a
difference at startup (scanning phase). My previous version of
open-zwave-shared showed also all the configuration commands as "value add".

Now however I only see values of the active sensor. Has somehow this
behaviour changed (I think my previous version was already month old)?

—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub #63 (comment).

[jbaron]

Testing some more and works fine (was able to set several command settings using the new identifier name)