Make node-openzwave-shared build on SmartOS #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix some tab vs spaces issues while there.
|
OK I think I fixed that, lets see what travis-ci thinks. |
|
@bahamas10 maybe you can have a quick scan over it? This is working fine for me. |
|
I tested this succesfully with node-red-contrib-openzwave after pointing to my own git repo instead of the npm version. Everything is working fine. |
|
I've also testes this against https://github.com/robertsLando/Zwave2Mqtt and everything is working fine too. So I am now fairly confident in this change. |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch recently landed that makes libopenzwave build on SmartOS, but looks like the node bindings need a bit of love too.
After these changes I can successfully build on SmartOS.