Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleToken example should inherit from ERC20Detailed #1458

Closed
come-maiz opened this issue Oct 20, 2018 · 1 comment · Fixed by #1473
Closed

SimpleToken example should inherit from ERC20Detailed #1458

come-maiz opened this issue Oct 20, 2018 · 1 comment · Fixed by #1473
Labels
documentation Inline comments, guides, and examples. good first issue Low hanging fruit for new contributors to get involved!

Comments

@come-maiz
Copy link
Contributor

​SimpleToken declares state variables for ​ name​, symbol​, and decimals​. We recommend inheriting from ​ERC20Detailed​ instead to demonstrate its usage.

This issue was reported in the LevelK audit.
@come-maiz come-maiz added good first issue Low hanging fruit for new contributors to get involved! kind:improvement documentation Inline comments, guides, and examples. labels Oct 20, 2018
@LaimeJesus
Copy link
Contributor

Hello, can I take this one?

LaimeJesus added a commit to LaimeJesus/openzeppelin-solidity that referenced this issue Oct 22, 2018
@LaimeJesus
add improvement in simpletoken example OpenZeppelin#1458
735d4f3
@LaimeJesus LaimeJesus mentioned this issue Oct 22, 2018
Merged
nventuro pushed a commit that referenced this issue Nov 1, 2018
@LaimeJesus @nventuro
add improvement in simpletoken example #1458 (#1473)
1186520 
* add improvement in simpletoken example #1458

* fix not calling decimals get function in initial supply
vittominacori added a commit to vittominacori/zeppelin-solidity that referenced this issue Nov 21, 2018
@vittominacori
Merge branch 'master' of https://github.com/vittominacori/zeppelin-so…
fd957c4 
…lidity into feature/token-recover

* 'master' of https://github.com/vittominacori/zeppelin-solidity: (98 commits)
  Renamed roles private variables to adhere to code style. (OpenZeppelin#1507)
  Remove extraneous quantity check, fixes OpenZeppelin#1454 (OpenZeppelin#1455)
  Remove redundant require statements (OpenZeppelin#1409)
  Add the step to delete the build dir to the RELEASE notes (OpenZeppelin#1467)
  add an address typecast to this per issue OpenZeppelin#1457 (OpenZeppelin#1471)
  add improvement in simpletoken example OpenZeppelin#1458 (OpenZeppelin#1473)
  SafeMath Test Coverage Improved (OpenZeppelin#1477)
  The beneficiary parameter of claimRefund is replaced with refundee (OpenZeppelin#1481)
  fix ERC20.sol#L174 and ERC20.sol#L187 should be casted to an address type. (OpenZeppelin#1470)
  Fix/add comment erc721 burnable OpenZeppelin#1464 (OpenZeppelin#1469)
  Release v2.0.0
  Release candidate v2.0.0-rc.4
  Improved some ERC721 internal shenanigans (OpenZeppelin#1450)
  Add warning about trading tokens before refundable crowdsale goal is met (OpenZeppelin#1452)
  Crowdsale.buyTokens is now nonReentrant. (OpenZeppelin#1438)
  InitialRate must be strictly larger than finalRate. (OpenZeppelin#1441)
  Fixed how allowance crowdsale checks remaining tokens. (OpenZeppelin#1449)
  Deleted unnecessary import. (OpenZeppelin#1437)
  Made SampleCrowdsale a bit clearer. (OpenZeppelin#1448)
  Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. (OpenZeppelin#1447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Inline comments, guides, and examples. good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add improvement in simpletoken example #1458 LaimeJesus/openzeppelin-solidity
2 participants
@come-maiz @LaimeJesus