Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GovernorCompatibilyBravo and add simpler GovernorStorage #4360

Merged
merged 69 commits into from
Aug 3, 2023

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    ef52cdc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f33a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Apply suggestions from code review

    Co-authored-by: Ernesto García <[email protected]>
    Amxx and ernestognw authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0eb90ca View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. wip

    Amxx committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    fb35e92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    841c80d View commit details
    Browse the repository at this point in the history
  3. refactor state checking

    Amxx committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4b97eb4 View commit details
    Browse the repository at this point in the history
  4. update docs

    Amxx committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0f89b6a View commit details
    Browse the repository at this point in the history
  5. fix lint

    Amxx committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1d7e28c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. _queue returns bool

    Amxx committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    79ad539 View commit details
    Browse the repository at this point in the history
  2. add changeset

    Amxx committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c1a6eee View commit details
    Browse the repository at this point in the history
  3. bool → eta

    Amxx committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    51b37ec View commit details
    Browse the repository at this point in the history
  4. minimize change

    Amxx committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f527b69 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d60a50 View commit details
    Browse the repository at this point in the history
  6. split internals function

    Amxx committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    67f808a View commit details
    Browse the repository at this point in the history
  7. Update contracts/governance/extensions/GovernorStorage.sol

    Co-authored-by: Ernesto García <[email protected]>
    Amxx and ernestognw authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9b76c86 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. wip

    Amxx committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    caf1fe8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30eb76c View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. fix lint

    Amxx committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    44e23cc View commit details
    Browse the repository at this point in the history
  2. test GovernorStorage

    Amxx committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    18c1e35 View commit details
    Browse the repository at this point in the history
  3. coverage

    Amxx committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    35d6359 View commit details
    Browse the repository at this point in the history
  4. lint

    Amxx committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    aeae17e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4f858e View commit details
    Browse the repository at this point in the history
  6. move proposalEta to core

    Amxx committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ce87721 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    57cad90 View commit details
    Browse the repository at this point in the history
  2. fix lint

    Amxx committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8b7788b View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    e7d2123 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    f2d55b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. remove proposalId from the internal function. It is now computed inte…

    …rnally and returned to the public functions
    Amxx committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a67ce0e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    c8717b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. improve docs

    frangio committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1b7a395 View commit details
    Browse the repository at this point in the history
  2. rename implemented -> queued

    frangio committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b97a4b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b828ced View commit details
    Browse the repository at this point in the history
  4. typo

    frangio committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    899b14b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    edd9c35 View commit details
    Browse the repository at this point in the history
  6. fix timelock id

    frangio committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    869836f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0091b82 View commit details
    Browse the repository at this point in the history
  8. revert on unknown proposalId

    frangio committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    331f8e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. lint

    frangio committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    d44e090 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef1c20f View commit details
    Browse the repository at this point in the history
  3. rename getters

    frangio committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    11ca422 View commit details
    Browse the repository at this point in the history
  4. update changeset

    frangio committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    977083a View commit details
    Browse the repository at this point in the history
  5. update changeset

    frangio committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    8084aa3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    5645ec8 View commit details
    Browse the repository at this point in the history
  2. _doQueue returns eta only

    Amxx committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9d2ac8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ccd0d47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d3d2396 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Apply suggestions from code review

    Co-authored-by: Ernesto García <[email protected]>
    frangio and ernestognw authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    440cedc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdddeda View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2445f8 View commit details
    Browse the repository at this point in the history
  4. improve _cancel docs

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2a8dfb3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    02e43ff View commit details
    Browse the repository at this point in the history
  6. improve definition of ETA

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    92589ff View commit details
    Browse the repository at this point in the history
  7. remove redundant docs

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e313b71 View commit details
    Browse the repository at this point in the history
  8. edit docs for queue

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    caf04b2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b01dad5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ec55fe1 View commit details
    Browse the repository at this point in the history
  11. add missing await

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6b352c4 View commit details
    Browse the repository at this point in the history
  12. fix variable

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6f99bc9 View commit details
    Browse the repository at this point in the history
  13. Revert "add missing await"

    This reverts commit 6b352c4.
    
    Revert "Batch GovernorStorage transactions setup"
    
    This reverts commit b2445f8.
    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    62f6fd6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    037831e View commit details
    Browse the repository at this point in the history
  15. lint

    frangio committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5e74069 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    8cb38ed View commit details
    Browse the repository at this point in the history
  2. make governor into interface

    frangio committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d861ec1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9240de View commit details
    Browse the repository at this point in the history
  4. lint

    frangio committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9e7f04e View commit details
    Browse the repository at this point in the history
  5. lint

    frangio committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d1d8e83 View commit details
    Browse the repository at this point in the history
  6. fix docs

    frangio committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ae58b64 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d2e54af View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1853702 View commit details
    Browse the repository at this point in the history