This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Rename Project, Network, Sesion and Lock files #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylv-io
force-pushed
the
feature/cli-config-files
branch
3 times, most recently
from
cf41eb2
to
0261f60
Compare
spalladino
reviewed
Jun 24, 2019
There was a problem hiding this comment.
Great work @ylv-io!! Again, thanks so much for tackling this! I think I spotted one issue only, and left a few comments as well.
ylv-io
force-pushed
the
feature/cli-config-files
branch
from
15ee951
to
88e28a3
Compare
ylv-io
force-pushed
the
feature/cli-config-files
branch
from
2256977
to
95ada9b
Compare
jbcarpanelli
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
LGTM!
Let's wait until we merge #1054 into master before merging this one.
|
#1054 Already merged. To master it goes! 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR renames config files according to:
While keeping backward compatibility to old config files. Every new config file will be created using new naming convention but old config won't be migrated and will be used as it is.
We are hopping to break legacy config file support during release of v3.0.