Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Support renaming for unpack #1078

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Support renaming for unpack #1078

merged 2 commits into from
Jul 9, 2019

Conversation

ylv-io
Copy link
Contributor

@ylv-io ylv-io commented Jul 9, 2019

Supports new starter kit for unpack command and provides backwards compatibility for zepkit.

@ylv-io ylv-io requested a review from jbcarpanelli July 9, 2019 14:11
jbcarpanelli
jbcarpanelli approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@jbcarpanelli jbcarpanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just added a nit, but it's not a blocker 🙂.

packages/cli/test/commands/unpack.test.js Outdated Show resolved Hide resolved
packages/cli/test/scripts/unpack.test.js Show resolved Hide resolved
@ylv-io ylv-io added the status:ready-to-merge Order mergify to merge label Jul 9, 2019
@mergify mergify bot merged commit 10bbbfd into master Jul 9, 2019
@mergify mergify bot deleted the feature/unpack-rename branch July 9, 2019 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbcarpanelli jbcarpanelli jbcarpanelli approved these changes

Assignees
No one assigned
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylv-io @jbcarpanelli