Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Get dependency version with caret #1146

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Get dependency version with caret #1146

merged 1 commit into from
Jul 22, 2019

Conversation

spalladino
Copy link
Contributor

Link a dependency version using the caret instead of exact version, and avoid relying on unix specific bash commands.

This allows linking a dependency like @openzeppelin/contracts-ethereum-package on version ^2.2.0. This installs version 2.2.1, but allows using deployments made under version 2.2.0.

Link a dependency version using the caret instead of exact version, and avoid relying on unix specific bash commands.

This allows linking a dependency like `@openzeppelin/contracts-ethereum-package` on version `^2.2.0`. This installs version 2.2.1, but allows using deployments made under version 2.2.0.
@spalladino spalladino requested a review from ylv-io July 22, 2019 17:23
Copy link
Contributor

@ylv-io ylv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question why we ignore patches?

@spalladino
Copy link
Contributor Author

My only question why we ignore patches?

Usually a bump in the patch does not imply a change in the deployed logic contracts. Using the caret allows us to use an older logic contract version with the new package.

@spalladino spalladino merged commit eb9316c into master Jul 22, 2019
@spalladino spalladino deleted the fix/pull-dep-version branch July 22, 2019 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants