This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add bootstrapping using a previous version of the CLI #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
approved these changes
Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #1293, we're currently using truffle to compile the contracts in this repo, and we want to migrate to our own CLI. There is an issue with using the CLI in the repo itself because of a circular dependency: the compiler depends on lib, and lib depends on the compiler to build itself.
To work around this, we have created a new
bootstrapself-contained package that installs a previous version of the CLI. Note that this is not part of the root Yarn workspaces because there were issues with hoisting that resulted in errors.This PR replaces #1293 because we thought that requiring a globally installed version of the CLI made the development setup cumbersome by not being self-contained, and this would deter external contributions.